the quality of my code is not very good, but there are basically no defects I can find after three changes. I understand that Leader also has its own things to do, but in the face of its own PR can not be merged for a long time, it is still very anxious.
Ps: I changed it once or twice before I mentioned PR. After all, it"s not easy to be pointed out to be mentally retarded.
so, how to effectively get others to CodeReview, for themselves without causing resentment?
Why do CodeReview others read slowly? The root cause of
is that the written code is illogical or poorly commented.
if you write code in the way you write a book, you will find that the logic is clear and others will look clear, so the speed will be faster.
think about it. If the logic is not clear, people will still want to read the code for a long time
1. First of all, you say that the quality of your code is not good, and you need to change it two or three times before there is basically nothing wrong with it. I think this question is very important. You must remember your mistakes and develop a good habit and code quality. Even if you mention PR, I don't think leader will resent it. After all, it is not a common mistake
2. You don't have to ask learder to look at the code first, you can test whether your own code works, whether all aspects of the situation are well considered, and you can ask colleagues to take a look at it after you are sure there is no problem, because it is always easier to find someone else's bug than to find it yourself. When all this is all right, you go to leader, again. I think the chance of something wrong is very small, and then you won't be pointed out as mentally retarded.
3. How to let others help you codereview, to find colleagues to help each other ah, check each other's code. This is fine, but this premise is that you should have a good code habit and quality, and don't always find some minor problems, which is a waste of everyone's time. Over time, people will not be willing to help you with codereview